[Uptime] Details page map handle geo information missing#54483
Merged
shahzad31 merged 66 commits intoelastic:masterfrom Jan 14, 2020
Merged
[Uptime] Details page map handle geo information missing#54483shahzad31 merged 66 commits intoelastic:masterfrom
shahzad31 merged 66 commits intoelastic:masterfrom
Conversation
…details-left-side-title
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
A few recommendations we should consider.
| isOpen={isPopoverOpen} | ||
| closePopover={togglePopover} | ||
| > | ||
| <EuiText style={{ width: '300px' }}> |
Contributor
There was a problem hiding this comment.
I think we can improve the formatting/messaging here a bit. This isn't perfect, but something along these lines:
<EuiText style={{ width: '300px' }}>
<FormattedMessage
id="xpack.uptime.locationMap.locations.missing.message"
defaultMessage="Important geo location configuration is missing. You can use the {test} field
to create distinctive geographic regions for your uptime checks."
values={{ test: <EuiCode>observer.geo.??</EuiCode> }}
/>
</EuiText>
<EuiSpacer size="xs" />
<EuiText style={{ width: '300px' }}>
<FormattedMessage
id="xpack.uptime.locationMap.locations.missing.message1"
defaultMessage="Get more information in
our documentation."
/>
</EuiText>
<EuiSpacer size="xs" />
<LocationLink />Renders something like this:
WDYT?
|
|
||
| if (monitorLocations?.locations) { | ||
| monitorLocations.locations.forEach((item: any) => { | ||
| if (item.summary.down === 0) { |
Contributor
There was a problem hiding this comment.
We should add some tests for this functionality, it's pretty nested.
Contributor
Author
There was a problem hiding this comment.
i have added tests.
Contributor
Author
There was a problem hiding this comment.
have updated the warning message format
…-geo-information-missing
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jan 15, 2020
* update API * update query * hide layer control and added loc tags * update test * remove unused comment * update API * remove capitalization * style fix * update types * added location status number on details page * useref instead of createRef * update interface * update import * removed redundant file * fix header for empty data * refactor for most recent check * remove redundant code * remone unused translation * update status bar * update styling * update snaps * added API tests * fix types * fixing integration tests and a typo * remove unused translations * update tests * fixed PR feedback * update feedback * update messaging * update snap * added timestamp in front of tags * update missing * update locs * update geo info missing * use formatted message * update snaps * updated types * update test * fix test * update tests * update more skipped tests * update test * update warning message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Jan 15, 2020
…4827) * update API * update query * hide layer control and added loc tags * update test * remove unused comment * update API * remove capitalization * style fix * update types * added location status number on details page * useref instead of createRef * update interface * update import * removed redundant file * fix header for empty data * refactor for most recent check * remove redundant code * remone unused translation * update status bar * update styling * update snaps * added API tests * fix types * fixing integration tests and a typo * remove unused translations * update tests * fixed PR feedback * update feedback * update messaging * update snap * added timestamp in front of tags * update missing * update locs * update geo info missing * use formatted message * update snaps * updated types * update test * fix test * update tests * update more skipped tests * update test * update warning message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* update API * update query * hide layer control and added loc tags * update test * remove unused comment * update API * remove capitalization * style fix * update types * added location status number on details page * useref instead of createRef * update interface * update import * removed redundant file * fix header for empty data * refactor for most recent check * remove redundant code * remone unused translation * update status bar * update styling * update snaps * added API tests * fix types * fixing integration tests and a typo * remove unused translations * update tests * fixed PR feedback * update feedback * update messaging * update snap * added timestamp in front of tags * update missing * update locs * update geo info missing * use formatted message * update snaps * updated types * update test * fix test * update tests * update more skipped tests * update test * update warning message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix : #54466
Handle use case where geo information is missing and show popover controlled by button over map.
Checklist
For maintainers